Fix verify email flow with no realm #887
Conversation
google-cla
bot
added
the
cla: yes
| // Verifying email requires the user is logged in | ||
| sub = r.PathPrefix("").Subrouter() | ||
| sub.Use(requireAuth) | ||
| sub.Use(rateLimit) |
There was a problem hiding this comment.
still feels like we should keep the rate limiter?
There was a problem hiding this comment.
see line 164. This merges it with the above subrouter which still has rate limiting
pkg/render/render.go
Outdated
| @@ -128,13 +128,18 @@ func loadTemplates(tmpl *template.Template, root string) error { | |||
| }) | |||
| } | |||
|
|
|||
| func unescape(s string) template.HTML { | |||
There was a problem hiding this comment.
Nit: I'd prefer to name this safeHTML or something instead? It's possible we might want to do the same for JS or CSS in the future.
There was a problem hiding this comment.
done. added a doc comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyfaller, sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/retest |
Fixes #873
Proposed Changes
Release Note