This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Move JS and CSS external #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This isn't all JS and CSS, just the big bits
sethvargo
force-pushed
the
sethvargo/reorg
branch
from
bf10956
to
ab083d3
Compare
mikehelmick
approved these changes
Oct 21, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't all JS and CSS, just the big bits. There's still a lot of inline JS that I didn't want to mess with.
Splitting this out now as I'd eventually like to run this through a minifier and potentially serve them from a different domain (but that's a P4). At the very least, this will cause browsers to cache them.
Release Note
/assign @whaught