This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Backup the Cloud SQL database to GCS every 6 hours #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
mikehelmick
suggested changes
Oct 21, 2020
mikehelmick
approved these changes
Oct 21, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: icco, mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| name = "${var.project}-backups" | ||
| location = var.storage_location | ||
|
|
||
| force_destroy = true |
There was a problem hiding this comment.
feels safer to me to have this be false(the default).
There was a problem hiding this comment.
This tells terraform to delete the objects in the bucket before deleting the bucket. GCS doesn't let you delete a bucket with objects inside.
There was a problem hiding this comment.
Yeah, I understood that. I felt it was kinda safer to require the bucket be empty.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #864
Nuances
Cloud SQL doesn't seem to support per-instance IAM, so we have to grant at the project level (yuck, but it's only viewer)
I'm relying on bucket versioning instead of actually naming the exports with a datetime. This is mostly a design decision to avoid needing a middle service. Ideally Cloud Scheduler would support a template syntax, but it does not.
The backups aren't compressed (for the same reason as above), but our last backup was 2MB. I'm not really worried about large databases for this project.
Backup time is configurable via the cron notation.
Release Note
/assign @jeremyfaller @icco