This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Use Android intent links in place of bouncing. #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This fixes behavior of Facebook Messenger when the app is installed (currently it always redirects to the store), and appears to generalize to more SMS clients. It also more closely matches this approach: https://firebase.google.com/docs/dynamic-links/operating-system-integrations NOTE: For iOS ENX, Store URL should be left blank, as no App Link triggers ENX. Custom Apps using the verification server currently can't do the "fancier" clipboard trick described in the link above, see: google#844 Intents are built according to: https://developer.chrome.com/multidevice/android/intents Which documents the URI scheme used here: https://android.googlesource.com/platform/frameworks/base/+/135936072b24b090fb63940aea41b408d855a4f3/core/java/android/content/Intent.java#6227
mikehelmick
approved these changes
Oct 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flagxor, mikehelmick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes behavior of Facebook Messenger when
the app is installed (currently it always redirects to the store),
and appears to generalize to more SMS clients.
It also more closely matches this approach:
https://firebase.google.com/docs/dynamic-links/operating-system-integrations
NOTE: For iOS ENX, Store URL should be left blank, as no App Link triggers ENX.
Custom Apps using the verification server currently can't do the
"fancier" clipboard trick described in the link above, see:
#844