Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Give system admins ability to clear caches #834

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

sethvargo
Copy link
Member

In some situations, a system admin may want to clear the caches, either
for development/testing or because a misconfiguration has made it into
the system. This introduces a way for system admins to perform cache
resets.

This required a bit of a refactor of the cacher, separating the
namespace property from the actual key value.

Fixes #821

Release Note

Give system admins the ability to clear (Redis) caches.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 15, 2020
@sethvargo
Copy link
Member Author

/assign @mikehelmick @whaught

pkg/cache/in_memory.go Show resolved Hide resolved
pkg/controller/admin/caches.go Outdated Show resolved Hide resolved
@whaught
Copy link
Contributor

whaught commented Oct 15, 2020

/hold
/lgtm

@sethvargo
Copy link
Member Author

@whaught @mikehelmick PTAnotherL

In some situations, a system admin may want to clear the caches, either
for development/testing or because a misconfiguration has made it into
the system. This introduces a way for system admins to perform cache
resets.

This required a bit of a refactor of the cacher, separating the
namespace property from the actual key value.
@sethvargo sethvargo force-pushed the sethvargo/yar_caches_be_cleared_matey branch from 9b4240e to 0d27925 Compare October 15, 2020 13:32
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 7a6fb4a into main Oct 15, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/yar_caches_be_cleared_matey branch October 15, 2020 14:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let admins clear caches via the UI
5 participants