-
Notifications
You must be signed in to change notification settings - Fork 83
use redirect hostname to lookup realm for correct mobile app #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits, but can be a follow up
func (c *Controller) getAndroidData(region string) ([]AndroidData, error) { | ||
realm, err := c.db.FindRealmByRegion(region) | ||
if err != nil { | ||
return nil, fmt.Errorf("unable to lookup realm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return nil, fmt.Errorf("unable to lookup realm") | |
return nil, fmt.Errorf("unable to lookup realm: %w", err) |
func (c *Controller) getIosData(region string) (*IOSData, error) { | ||
realm, err := c.db.FindRealmByRegion(region) | ||
if err != nil { | ||
return nil, fmt.Errorf("unable to lookup realm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return nil, fmt.Errorf("unable to lookup realm") | |
return nil, fmt.Errorf("unable to lookup realm: %w", err) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #779
Proposed Changes
Release Note