Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Switch show-code to GET #777

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Switch show-code to GET #777

merged 1 commit into from
Oct 7, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Oct 7, 2020 •
edited
Loading

Issue #232

Proposed Changes

  • Switch the show-code page from POST to GET
  • Use hrefs for the code-list for better navigation (less javascript magic)

Release Note

Moved the /code/show page to GET /code/show/{uuid}

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 7, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit afd2e1c into google:main Oct 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikehelmick mikehelmick mikehelmick approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whaught @google-oss-robot @mikehelmick @sethvargo @googlebot