Log metric for in use hosts #759

icco · 2020-10-06T21:18:07Z

Proposed Changes

Adds new metric which counts requests per host in logs so we can see what domains are actually being used.

Release Note

Creates a new metric in the logging module from cloud run logs for counting what hosts are being used by clients.

google-oss-robot · 2020-10-06T21:24:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, mikehelmick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

icco and others added 6 commits October 6, 2020 01:20

init

8f8a7e8

whitespace

ffa649a

first pass

b0ef5bb

Merge remote-tracking branch 'upstream/main' into log-metric

22c4cff

Fix regex

b0fc130

Fix escaping

497b28a

google-oss-robot requested review from jeremyfaller, mikehelmick and sethvargo October 6, 2020 21:18

google-oss-robot added the approved label Oct 6, 2020

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 6, 2020

google-oss-robot added the size/S label Oct 6, 2020

mikehelmick approved these changes Oct 6, 2020

View reviewed changes

google-oss-robot assigned mikehelmick Oct 6, 2020

google-oss-robot added the lgtm label Oct 6, 2020

google-oss-robot merged commit 10cd709 into google:main Oct 6, 2020

icco deleted the log-metric branch October 6, 2020 21:26

icco mentioned this pull request Oct 6, 2020

Forgot project field for requests_by_host metric #761

Merged

github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020