This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Recreate firebase user, no metric #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
jeremyfaller
suggested changes
Oct 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sethvargo
reviewed
Oct 6, 2020
| @@ -81,16 +81,9 @@ func (c *Controller) HandleCreate() http.Handler { | |||
| } | |||
|
|
|||
| // Create firebase user first, if this fails we don't want a db.User entry | |||
| if created, err := user.CreateFirebaseUser(ctx, c.client); err != nil { | |||
| flash.Alert("Failed to create user: %v", err) | |||
| if _, err := c.createFirebaseUser(ctx, user); err != nil { | |||
| c.renderNew(ctx, w) | |||
There was a problem hiding this comment.
I don't think we should swallow this error.
There was a problem hiding this comment.
it's not swallowed. c.createFirebaseUser does the flash now (the flash is the same for the places that use the helper)
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
**Note: ** This does send the user back through the email verification flow (which is currently bundled with our password-reset invitation and therefore not seen by most users)
This PR fixes the issue without adding a metric. That will be done as a separate PR. See #685
Release Note