This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Attempt to fix realm quota alert #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display the currently configured limit and remaining tokens on the realm settings page. - Only create the metrics for realms that have abuse prevention enabled.
sethvargo
commented
Oct 2, 2020
| return | ||
| } | ||
| key := fmt.Sprintf("realm:quota:%s", dig) | ||
| limit, remaining, reset, ok, err := c.limiter.Take(ctx, key) | ||
| c.recordCapacity(ctx, limit, remaining) |
There was a problem hiding this comment.
Moved this up - we were only recording capacity later, which I think would cause us to miss some data points.
| if !realm.AbusePreventionEnabled { | ||
| return | ||
| } | ||
| func (c *Controller) recordCapacity(ctx context.Context, limit, remaining uint64) { |
There was a problem hiding this comment.
I changed this to rely on the value that comes from the limiter, not the value on the realm. The enforcement happens based on what's in the limiter, so we should alert and record off of that.
jeremyfaller
approved these changes
Oct 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyfaller, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #735
Release Note