Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Respond to paste, keyup, and change #741

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Oct 2, 2020

Proposed Changes

  • Password select/change should respond to both keyup, paste, and change to handle all methods of input
    • It currently assumes the user is typing

Release Note

Password validation responds to copy/paste

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 2, 2020
@whaught
Copy link
Contributor Author

whaught commented Oct 2, 2020

/assign @sethvargo

Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 5748bae into google:main Oct 2, 2020
@whaught whaught deleted the onkeyup branch October 2, 2020 18:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants