Include knative info in metrics if present #736
Conversation
google-cla
bot
added
the
cla: yes
|
/assign @yegle |
| tags = append(tags, tag.Upsert(BuildIDTagKey, buildinfo.BuildID)) | ||
| tags = append(tags, tag.Upsert(BuildTagTagKey, buildinfo.BuildTag)) | ||
|
|
||
| if knativeService != "" { |
There was a problem hiding this comment.
Either log it when it's empty, or add the tag even if the value is empty.
Per the Cloud Run contract, the env var should not be empty. When they are empty, we won't want to silently ignore the issue.
There was a problem hiding this comment.
We want to support cases where this runs outside of Cloud Run though. We know other people are running this code on other platforms. We aren't specifically tied to GCP.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, yegle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release Note