Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Trim whitespace from user-input #729

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Trim whitespace from user-input #729

merged 1 commit into from
Oct 1, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Oct 1, 2020

Fixes #726

Proposed Changes

  • Trim whitespace from a few user-input spots
    • User name/email input
    • Login email input
    • Login MFA code input

Release Note

Trim whitespace from login and create-user inputs

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 1, 2020
@whaught
Copy link
Contributor Author

whaught commented Oct 1, 2020

/assign @sethvargo @mikehelmick

@jeremyfaller
Copy link
Contributor

Possibly, slightly easier (rather than introducing locals) would have been to just TrimSpace on form, throughout.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@whaught
Copy link
Contributor Author

whaught commented Oct 1, 2020

/retest

@google-oss-robot google-oss-robot merged commit b32e3a7 into google:main Oct 1, 2020
sethvargo
sethvargo reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whaught whaught deleted the just-a-trim branch October 1, 2020 19:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo left review comments

@mikehelmick mikehelmick mikehelmick approved these changes

@yegle yegle Awaiting requested review from yegle

Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim space on MFA code before checking
6 participants
@whaught @jeremyfaller @google-oss-robot @mikehelmick @sethvargo @googlebot