Show all password validations #681

whaught · 2020-09-25T18:53:08Z

Proposed Changes

We currently exit early and only show the first thing wrong with password validation.
- Show them all
- Show password / retyped password match validation

Release Note

Password complexity validation UI shows all validation stats (not just first failure)

google-oss-robot · 2020-09-25T19:12:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Show all password vaidation

542b642

google-oss-robot requested review from sethvargo and yegle September 25, 2020 18:53

google-oss-robot added the approved label Sep 25, 2020

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 25, 2020

google-oss-robot added the size/S label Sep 25, 2020

mikehelmick approved these changes Sep 25, 2020

View reviewed changes

google-oss-robot assigned mikehelmick Sep 25, 2020

google-oss-robot added the lgtm label Sep 25, 2020

google-oss-robot merged commit fe07f19 into google:main Sep 25, 2020

whaught deleted the all-the-validation branch September 25, 2020 21:06

github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020