Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Server-side password reset #668

Merged
merged 17 commits into from
Sep 24, 2020
Merged

Server-side password reset #668

merged 17 commits into from
Sep 24, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 24, 2020

Proposed Changes

  • Moves the password-reset logic to the server-side
    • Allows us to better hide the not-found response if the user email isn't in our system

Release Note

Move password reset call to the server

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 24, 2020
sethvargo
sethvargo suggested changes Sep 24, 2020
View reviewed changes
cmd/server/assets/login/reset-password.html Show resolved Hide resolved
cmd/server/main.go Show resolved Hide resolved
internal/firebase/error.go Outdated Show resolved Hide resolved
internal/firebase/error.go Show resolved Hide resolved
internal/firebase/password_reset_email.go Outdated Show resolved Hide resolved
pkg/controller/login/reset_password.go Outdated Show resolved Hide resolved
pkg/controller/login/reset_password.go Outdated Show resolved Hide resolved
pkg/controller/login/reset_password.go Show resolved Hide resolved
sethvargo
sethvargo reviewed Sep 24, 2020
View reviewed changes
internal/firebase/error.go Outdated Show resolved Hide resolved
pkg/controller/login/reset_password.go Outdated Show resolved Hide resolved
internal/firebase/error.go Outdated Show resolved Hide resolved
internal/firebase/error.go Outdated Show resolved Hide resolved
@whaught
Copy link
Contributor Author

whaught commented Sep 24, 2020

/hold

@whaught
Copy link
Contributor Author

whaught commented Sep 24, 2020

/unhold

tested that it works

sethvargo
sethvargo approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d9c7eb5 into google:main Sep 24, 2020
@whaught whaught deleted the send-reset-server branch September 25, 2020 01:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@icco icco Awaiting requested review from icco

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot