Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Make sure password change time is something #661

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Make sure password change time is something #661

merged 1 commit into from
Sep 23, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 23, 2020

Proposed Changes

  • Password change will be the account creation time if the new column is unset
  • "unknown" string for the UI just in case, but we don't expect to see that

Release Note

Password creation time field falls back to user creation time

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 23, 2020
sethvargo
sethvargo approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit f7400f7 into google:main Sep 23, 2020
@whaught whaught deleted the zero-value branch September 23, 2020 23:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@icco icco Awaiting requested review from icco

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whaught @google-oss-robot @sethvargo