Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Make certificate swapping easier for enx-redirect #653

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

icco
Copy link
Contributor

@icco icco commented Sep 23, 2020

Proposed Changes

  • If you are using enx-redirect, and you modify the map variable, this will recreate the cert, which will create unknown amounts of downtime. So instead, you need to manually create a new cert with the new domains, append it to the FE, and then wait for it to become healthy, and then change the FE again by removing the old cert.
  • This changes the FE to use two certs, so that the "main" cert is just www. and then the region domains are on a separate cert, this makes the above process easier.
  • Also split the two LBs into separate files.

Release Note

Changes the certificates on the redirect server.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 23, 2020
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@icco icco added the lgtm label Sep 23, 2020
@google-oss-robot google-oss-robot merged commit 996cc0a into google:main Sep 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
@icco icco deleted the certs-are-hard branch October 6, 2020 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants