Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add application-level per-realm firewall configuration #644

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

sethvargo
Copy link
Member

This adds per-realm firewall settings (by allowed CIDR blocks) for the adminapi, apiserver, and main server.

Release Note

Add per-realm firewall security settings

/assign @mikehelmick

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 23, 2020
@mikehelmick
Copy link
Contributor

/hold

I think this is dangerous for api server - that’s intended to be accessed by mobile devices

@sethvargo
Copy link
Member Author

I wrote the help text to strongly discourage people from enabling the firewall against the apiserver, but I do think there's a legit use case where someone running their own server might want to do so. For example, they might be running a staging server and want to restrict devices on a particular subnet from uploading to it. One could argue they should add that protection at another layer, but I do see the use case.

@sherifkozman
Copy link
Contributor

@sethvargo i believe it had to be on a different layer as well , where logging will be normally available in case the wrong CIDR block is added there will be no way to trace or debug.

@sethvargo
Copy link
Member Author

@sherifkozman the logs will include a message if a request is blocked due to the IP. It won't tell you which IP, but you can correlate it to timestamps.

This can't be higher in the stack because it's a realm-level configuration, and users can be a member of multiple realms. For example, Jacky might be able to access realm1 from anywhere, but can only access realm2 from a corporate IP subnet.

@sethvargo
Copy link
Member Author

@mikehelmick PTAnotherL

@mikehelmick
Copy link
Contributor

@mikehelmick PTAnotherL

👁️ looking

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 78b7b9e into main Sep 23, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/firewall branch September 23, 2020 18:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants