Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Create a login page for re-authing a user #639

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 22, 2020

Issue #609

Proposed Changes

  • Creates and serves the login page without the /home redirect
  • Pre-fill email field if session has a user alreadu
  • Calls reauthenticateWithCredential for existing user
  • Allows the session to specify a redirect on success. This will be used to get back to the phone, email change, or password change page respectively.

Release Note

Created a login page for re-authorizing an already logged-in user

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 22, 2020
@@ -22,7 +22,7 @@
<form id="login-form" class="floating-form" action="/" method="POST">
<div class="form-label-group">
<input type="email" id="email" name="email" class="form-control" placeholder="Email address" required
autofocus />
autofocus {{if .currentUser}}disabled value="{{.currentUser.Email}}"{{end}}/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an easy way to escape off this page and log in as someone else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Added the nav header in.

This is currently a bit of a dead end anyway since it's not linked in anywhere

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 6e35ef0 into google:main Sep 22, 2020
@whaught whaught deleted the reauth branch September 23, 2020 00:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants