Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Allow deletion of factors #628

Merged
merged 13 commits into from
Sep 22, 2020
Merged

Allow deletion of factors #628

merged 13 commits into from
Sep 22, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 22, 2020 •
edited
Loading

Issue #608

Proposed Changes

  • If there are enrolled factors, show them in a list
  • Delete link for removing an enrolled factor
  • Minor fix to make pin-confirm div hide on success

oncemore

Release Note

Allow users to delete enrolled factor for MFA

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 22, 2020
sethvargo
sethvargo suggested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be any kind of check/warning if any of the user's realms require MFA and they are about to remove their last MFA device?

cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
cmd/server/assets/login/register-phone.html Outdated Show resolved Hide resolved
sethvargo
sethvargo approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 17d6347 into google:main Sep 22, 2020
@whaught whaught deleted the manage-mfa branch September 22, 2020 16:00
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot