Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Hide ENX settings once enabled behind advanced panel #623

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

sethvargo
Copy link
Member

Release Note

Make it more difficult to accidentally disable ENX

/cc @mikehelmick
/assign @whaught

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 21, 2020
@sethvargo
Copy link
Member Author

screenshot-20200921-183115@2x

@sethvargo
Copy link
Member Author

screenshot-20200921-183118@2x

Copy link
Contributor

@whaught whaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit ef88529 into main Sep 21, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/settings branch September 21, 2020 23:14
@whaught
Copy link
Contributor

whaught commented Sep 21, 2020

I did find in my browser that if I go to #something and then click in the

dropdown setting, my browser set it to #general but the page didn't actually go there. Weird stuff.

@sethvargo
Copy link
Member Author

Yea, I noticed that too and I think it's actually a bug in bootstrap 😦. I couldn't find a good solution.

@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants