Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

As you type verify password #602

Merged
merged 1 commit into from
Sep 19, 2020
Merged

As you type verify password #602

merged 1 commit into from
Sep 19, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 19, 2020

Fixes #600

Proposed Changes

  • As-your-type verify the user's password for more feedback
  • Fixes an issue where the [mistakenly] included loginscript redirects if the user is already logged-in

Release Note

as-you-type password validation
fix redirects from password change page

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 19, 2020
@sethvargo
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot merged commit 4678bc0 into google:main Sep 19, 2020
@whaught whaught deleted the remove-login-pwd-change branch September 21, 2020 14:46
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

@yegle yegle Awaiting requested review from yegle

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password reset link forces password reset
4 participants
@whaught @google-oss-robot @sethvargo @googlebot