This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Update UX on realm settings #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-cla
bot
added
the
cla: yes
|
/assign @whaught |
|
The one odd thing here is that the menu goes to settings#general It causes the page to load the first tab and quickly switch to the second. The user sees a weird flicker every time they load the page. Maybe just make 'General' the first tab? |
|
I think we can set "active" on that first tab? We have to wait for the dom to load to pick the right tab |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the UX on the realm settings page to be tabular. There's currently a lot of settings and they aren't logically grouped - this changes that to group various settings within a tab.
Release Note