Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Create an account settings page #599

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Create an account settings page #599

merged 8 commits into from
Sep 22, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 19, 2020 •
edited
Loading

Proposed Changes

  • Create a my-account page with the current user's information

TODO: this is where we will link in

  1. Better password change (no email)
  2. Change phone / unenroll 2nd factor
  3. Change email and re-verify?

myaccount

Release Note

Created a 'my account' page for the current user's settings

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 19, 2020
sethvargo
sethvargo reviewed Sep 19, 2020
View reviewed changes
cmd/server/assets/login/account.html Outdated Show resolved Hide resolved
cmd/server/assets/login/account.html Outdated Show resolved Hide resolved
cmd/server/assets/login/account.html Outdated Show resolved Hide resolved
cmd/server/assets/login/account.html Outdated Show resolved Hide resolved
pkg/controller/login/account.go Show resolved Hide resolved
whaught
whaught commented Sep 19, 2020
View reviewed changes
pkg/database/user.go Outdated Show resolved Hide resolved
sethvargo
sethvargo approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit ba7bf91 into google:main Sep 22, 2020
@whaught whaught deleted the my-settings branch September 22, 2020 03:45
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

@yegle yegle Awaiting requested review from yegle

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot