Redirect to show page after user-create #598

whaught · 2020-09-19T04:27:58Z

Proposed Changes

Redirect the user to the show-user page after creation
- The current experience is potentially confusing as the user winds up back at the new-user page (despite the flash alert). This makes it more clear that the user is created.
Adds a send-password reset button to the user page so admins can resend the reset if need-be.

Release Note

Add password-reset button for admins
Change new-user redirect to show-user

pkg/controller/user/create.go

pkg/controller/user/show.go

sethvargo

/gltm

google-oss-robot · 2020-09-19T18:23:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sethvargo · 2020-09-19T18:23:01Z

/lgtm

User to index page

527d1c0

google-oss-robot requested review from icco and sethvargo September 19, 2020 04:28

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 19, 2020

google-oss-robot added approved labels Sep 19, 2020

this is an admin page

ec13ae3

sethvargo suggested changes Sep 19, 2020

View reviewed changes

pkg/controller/user/create.go Show resolved Hide resolved

pkg/controller/user/show.go Show resolved Hide resolved

google-oss-robot assigned sethvargo Sep 19, 2020

whaught added 2 commits September 19, 2020 07:35

keep returns

68f750b

user create

56e15d3

sethvargo approved these changes Sep 19, 2020

View reviewed changes

google-oss-robot added the lgtm label Sep 19, 2020

google-oss-robot merged commit 7f89d44 into google:main Sep 19, 2020

whaught deleted the redirect-user branch September 21, 2020 14:46

google locked and limited conversation to collaborators Oct 6, 2020