Issue582 #597
Issue582 #597
Conversation
google-cla
bot
added
the
cla: yes
| } else { | ||
| text = strings.ReplaceAll(text, SMSENExpressLink, | ||
| fmt.Sprintf("https://%s.%s/v?c=%s", | ||
| strings.ToLower(r.RegionCode), |
There was a problem hiding this comment.
I don't think we currently enforce uniqueness on region codes right now, just realm names. Should we add a database constraint for that?
There was a problem hiding this comment.
we can file an issue for that. I'm not confident it would help anything since it's only specific to one sever
|
I think it needs a rebase |
mikehelmick
force-pushed
the
issue582
branch
from
9d4ac02
to
df961f0
Compare
| @@ -180,27 +180,39 @@ | |||
| {{if $realm.EnableENExpress}} | |||
| Your SMS template <em>MUST</em> contain <code>[enslink]</code>. | |||
| <ul> | |||
| <li><code>[enslink]</code> Inserts the required EN Express link of: <code>ens://v?r=[region]&c=[longcode]</code></li> | |||
| {{if eq "" .enxRedirectDomain}} | |||
| <li><code>[enslink]</code> Inserts the required EN Express link of: <code>ens://v?r=[region]&c=[longcode]</code></li> <li><code>[enslink]</code> Inserts the required EN Express link of: <code>ens://v?r=[region]&c=[longcode]</code></li> | |||
There was a problem hiding this comment.
This looks like this line is twice (see column like 120)
| @@ -180,27 +180,39 @@ | |||
| {{if $realm.EnableENExpress}} | |||
| Your SMS template <em>MUST</em> contain <code>[enslink]</code>. | |||
| <ul> | |||
| <li><code>[enslink]</code> Inserts the required EN Express link of: <code>ens://v?r=[region]&c=[longcode]</code></li> | |||
| {{if eq "" .enxRedirectDomain}} | |||
There was a problem hiding this comment.
I think you can just do {{if .enxRedirectDomain}}
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #536
Fixes #582
Proposed Changes
ens://links are preservedRelease Note