Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Realm setting for password rotation #592

Merged
merged 8 commits into from
Sep 19, 2020
Merged

Realm setting for password rotation #592

merged 8 commits into from
Sep 19, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 18, 2020 •
edited
Loading

Issue #575

Proposed Changes

  • Adds two new settings
    • Require password rotation at N days
    • Warn users about upcoming rotation at N days before expiry

withhelp

Release Note

New realm setting for password rotation requirements

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 18, 2020
sethvargo
sethvargo suggested changes Sep 18, 2020
View reviewed changes
pkg/controller/realmadmin/save.go Outdated Show resolved Hide resolved
cmd/server/assets/realm.html Outdated Show resolved Hide resolved
cmd/server/assets/realm.html Outdated Show resolved Hide resolved
@sethvargo
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot merged commit 44a56d0 into google:main Sep 19, 2020
@whaught whaught deleted the pwd-realm-settings branch September 19, 2020 00:06
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo requested changes

@icco icco Awaiting requested review from icco

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whaught @google-oss-robot @sethvargo