Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Create a password selection page #568

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 18, 2020

Proposed Changes

  • Adds a new password selection page
    • TODO: validate introduce length / complexity requirements.

Release Note

Add a password selection page

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 18, 2020
@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 18, 2020
let urlVars = getUrlVars();
let code = urlVars["oobCode"];

firebase.auth().verifyPasswordResetCode(code ?? "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? is not supported in IE

@sethvargo
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot merged commit 51bf944 into google:main Sep 18, 2020
@whaught whaught deleted the pwd-reset branch September 18, 2020 16:39
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants