Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

OTP entry form instead of window alert #556

Merged
merged 9 commits into from
Sep 17, 2020
Merged

OTP entry form instead of window alert #556

merged 9 commits into from
Sep 17, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Sep 17, 2020 •
edited
Loading

Fixes #545

Proposed Changes

  • Create a custom html pin form for login and registerphone
  • Resend SMS link is disabled and enables on a 15s timer.
  • Use the close-icon to return to previous
  • Some css tweaks

pinform

register

Release Note

Use custom html for entering SMS pin

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 17, 2020
@whaught whaught changed the title pin entry form instead of window alert Pin entry form instead of window alert Sep 17, 2020
sethvargo
sethvargo reviewed Sep 17, 2020
View reviewed changes
cmd/server/assets/header.html Outdated Show resolved Hide resolved
cmd/server/assets/header.html Outdated Show resolved Hide resolved
cmd/server/assets/login/_loginscripts.html Outdated Show resolved Hide resolved
cmd/server/assets/login/_loginscripts.html Outdated Show resolved Hide resolved
cmd/server/assets/login/login.html Outdated Show resolved Hide resolved
cmd/server/assets/login/login.html
$pinDiv.hide();
});

$resendPin.on('click', function(event) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to prevent default here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a link with no href, not a submit button?

@whaught whaught changed the title Pin entry form instead of window alert OTP entry form instead of window alert Sep 17, 2020
@sethvargo
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot merged commit 8c6539d into google:main Sep 17, 2020
@whaught whaught deleted the html-pin branch September 17, 2020 16:27
@google google locked and limited conversation to collaborators Oct 6, 2020
flagxor pushed a commit that referenced this pull request Aug 11, 2021
@crwilcox
Change key terminology to be more consistent, fixes #556 (#658)
a83e144
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo left review comments

@icco icco Awaiting requested review from icco

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve 2FA SMA enrollment
4 participants
@whaught @google-oss-robot @sethvargo @googlebot