Logic for batch user import #553
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
| </main> | ||
|
|
||
| {{template "scripts" .}} | ||
| <script type="text/javascript"> |
There was a problem hiding this comment.
Hmmm this is a lot of javascript. Is there a strong reason to do this on the client vs the server? It seems like a traditional form submit + background processing would suffice here.
There was a problem hiding this comment.
I'm also worried about the "modern" requirements here. When you think about most hospitals and medical facilities, they aren't running the latest and greatest browsers. I wouldn't be surprised if we have some clients using IE on XP still, with no support for the HTML5 file objects.
There was a problem hiding this comment.
The main reason is so that it can batch and update progress as it goes. If we submit the whole file, we still need to return a response with all the users so we can do the password reset in javascript.
whaught
changed the title
|
@whaught looks like there's test failures |
|
/lgtm |
Issue #517
Proposed Changes
* That might be a no-go for very old browsers, so leaving the Beta flash up
Release Note