Add variable monitoring-host-project to alerting module.

[yegle]

For multi-project workspaces, a separate empty monitoring host project
is preferred.

Related issue: #460

Release Note

action required: if you use the "alerting" Terraform module, you need to change var.project to var.monitoring-host-project. It's recommended to use a separate empty project to host the monitoring workspace. See also https://cloud.google.com/monitoring/workspaces/create#multi-project-ws

[yegle]

/assign @icco

[icco]

So my concern with this is what happens when monitoring host project is set in different terraform workspaces like we have?

[yegle]

Not sure if Terraform can do the work (you can merge one workspace into another workspace, i.e. "migrate" two single project workspace into a multi-project workspaec), but worst thing that could happen, we have to destroy everything in the old single-project workspace, and recreate everything in the multi-project workspace.

[yegle]

Oh I see what you mean.

I'm thinking about 3 different projects as variables, monitoring-host-project, key-server-project, verification-server-project. We can then use the alerting module outside of key/verification server.

This should be done in a later PR.

[icco]

Hmm, the more I think about it, I wonder if we should put this in a separate repo, as this is essentially growing the scope to outside of the verification server.

Thoughts?

[yegle]

SGTM

[icco]

/close

AI: create new repo called exposure-notifications-monitoring or something

[google-oss-robot]

@icco: Closed this PR.

In response to this:

/close

AI: create new repo called exposure-notifications-monitoring or something

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yegle]

@icco Let's maintain the monitoring related Terraform configs here for now?

[icco]

@icco Let's maintain the monitoring related Terraform configs here for now?

Yeah, but I think we should revert this? Seems unnecessary for now?

[icco]

We talked about this, merging.

/lgtm
/approve

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, yegle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [icco,yegle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment