Create empty page for user import. #539
Conversation
google-cla
bot
added
the
cla: yes
cmd/server/assets/realmstats.html
Outdated
| @@ -20,7 +20,7 @@ <h1>Realm stats</h1> | |||
| The data below shows realm statistics. | |||
| </p> | |||
|
|
|||
| <div class="card mb-3 shadow-sm"> | |||
| <div class="card mb-3 shadow-sm" style="min-width:950px;"> | |||
There was a problem hiding this comment.
Can be a follow-up, but it'd be good to make this a class.
There was a problem hiding this comment.
Actually I think I've fixed it. we have table-responsive which (on purpose) is for tables that should scroll as the div around them collapses. To your point, I think that is weird (especially on mobile), so I've just removed that and it seems to display properly.
We might want to remove responsive tables elsewhere too
cmd/server/assets/users/index.html
Outdated
| </a> | ||
| </tbody> | ||
| </table> | ||
| {{if .pages}} |
There was a problem hiding this comment.
We shouldn't do it in this PR, but I wonder if this makes sense to be a function of the renderer instead? Then the HTML just becomes:
{{ paginate $pages }}and the renderer builds this HTML. Then we can make it portable across any pages that need pagination.
| @@ -311,6 +311,7 @@ func realMain(ctx context.Context) error { | |||
| userSub.Handle("", userController.HandleIndex()).Queries("offset", "{[0-9]*?}").Methods("GET") | |||
| userSub.Handle("", userController.HandleCreate()).Methods("POST") | |||
| userSub.Handle("/new", userController.HandleCreate()).Methods("GET") | |||
| userSub.Handle("/import", userController.HandleImport()).Methods("GET") | |||
There was a problem hiding this comment.
I think you'll want to handle GET and POST here, then switch inside the function to determine whether you want to render the form or process the input.
There was a problem hiding this comment.
I'll add that in the PR that implements the import functionality for-reals
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Issue #517
Proposed Changes