This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Backfill realm stats based on user and apikey stats #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sethvargo
force-pushed
the
sethvargo/backfill_realm_stats
branch
from
29c4dca
to
0cdc7e4
Compare
mikehelmick
approved these changes
Sep 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MushuEE
reviewed
Sep 11, 2020
| ID: "00040-BackfillRealmStats", | ||
| Migrate: func(tx *gorm.DB) error { | ||
| logger.Debugw("db migrations: back-filling realm stats") | ||
| sqls := []string{ |
There was a problem hiding this comment.
I don't think it is worth the over haul now but would it be safer and more performant to use batch calls?
*I just started learning about this so I don't have a good understanding of the true advantages of removing round trip to database between calls.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the existing stats we've been collecting to backfill them onto the realm stats. It only includes backfill up to 9/15, which is when we'll cut a new release.
Release Note