This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Switch to APIKey+IP rate limiting, HMAC values #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
/assign @mikehelmick |
sethvargo
force-pushed
the
sethvargo/ratelimit_apikey_ip
branch
2 times, most recently
from
91c53bb
to
6a46ae3
Compare
mikehelmick
reviewed
Sep 11, 2020
sethvargo
force-pushed
the
sethvargo/ratelimit_apikey_ip
branch
from
6a46ae3
to
7c342ce
Compare
|
@mikehelmick fixed - PTanotherL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: icco, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes rate limiting for API keys to be "per API key realm, per IP" to reduce the chance of someone being able to DOS the system if they were to uncover an API key.
It also switches to HMAC (instead of just hash) the values before they are stored in Redis.
Release Note