This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add dashboards to be managed by Terraform. #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This looks like it includes some changes from your other PR - is that intended? |
sethvargo
reviewed
Sep 8, 2020
yegle
force-pushed
the
dashboards-in-terraform
branch
from
702740f
to
c7fb8c0
Compare
yegle
force-pushed
the
dashboards-in-terraform
branch
from
c7fb8c0
to
2555791
Compare
That was intended. I was trying to chain the changes and base this change on my other unmerged changes. It's ready to review now. |
NOTE: the chart on metric custom.googleapis.com/opencensus/en-verification-server/ratelimit/limitware/rate_limited_count was removed as it's no longer exported by the code.
yegle
force-pushed
the
dashboards-in-terraform
branch
from
53f8f77
to
282a864
Compare
|
Gentle ping? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, yegle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yegle
added a commit
to yegle/exposure-notifications-verification-server
that referenced
this pull request
Sep 11, 2020
This was incorrectly removed in google#494.
yegle
added a commit
to yegle/exposure-notifications-verification-server
that referenced
this pull request
Sep 11, 2020
This was incorrectly removed in google#494.
google-oss-robot
pushed a commit
that referenced
this pull request
Sep 11, 2020
This was incorrectly removed in #494.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: the chart on metric
custom.googleapis.com/opencensus/en-verification-server/ratelimit/limitware/rate_limited_count
was removed as it's no longer exported by the code.
The API requires JSON config but writing multi-line strings in JSON is PITA. I've decided to write it in YAML which is more compact and easier to write multi-line queries.
Related issue: #460
Release Note