Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Remove the callback library causing race issue #489

Merged
merged 9 commits into from
Sep 8, 2020
Merged

Remove the callback library causing race issue #489

merged 9 commits into from
Sep 8, 2020

Conversation

taddari
Copy link
Contributor

@taddari taddari commented Sep 8, 2020 •
edited
Loading

Fixes #267
Thanks Seth for catching the problem.

Proposed Changes

  • Removed the callback library that was causing race issues.
  • This PR just overrides the driver, so there should be no problem.
  • opencensus postgresql will show the metrics only. As there is no tracing involved, there is no need to pass the context.
Following metrics will be available https://github.com/opencensus-integrations/ocsql#metrics

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 8, 2020
@taddari
Copy link
Contributor Author

taddari commented Sep 8, 2020

/assign @icco

@icco
Copy link
Contributor

icco commented Sep 8, 2020

See also https://github.com/google/exposure-notifications-verification-server/pull/487/files

@icco
Copy link
Contributor

icco commented Sep 8, 2020

/assign @sethvargo

sethvargo
sethvargo reviewed Sep 8, 2020
View reviewed changes
pkg/database/database.go Outdated Show resolved Hide resolved
pkg/database/database.go Outdated Show resolved Hide resolved
pkg/database/database.go Outdated Show resolved Hide resolved
pkg/database/database.go Outdated Show resolved Hide resolved
pkg/database/database.go Outdated Show resolved Hide resolved
@sethvargo
Copy link
Member

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo, taddari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 752cbb7 into google:main Sep 8, 2020
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo left review comments

@mikehelmick mikehelmick mikehelmick approved these changes

Assignees

@icco icco

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open Census for Postgresql
5 participants
@taddari @icco @sethvargo @google-oss-robot @mikehelmick