Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add favicon and stuff #473

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Add favicon and stuff #473

merged 2 commits into from
Sep 3, 2020

Conversation

sethvargo
Copy link
Member

Fixes GH-471

Release Note

Add favicon and mobile assets

/assign @icco

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 3, 2020
@sethvargo
Copy link
Member Author

/hold

@icco
Copy link
Contributor

icco commented Sep 3, 2020

/lgtm

I personally like the all black one the best. The red color doesn't do it for me.

@sethvargo
Copy link
Member Author

/unhold

@sethvargo
Copy link
Member Author

@icco can you look again - I forgot to, ya know, serve the files

Copy link
Contributor

@icco icco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@icco
Copy link
Contributor

icco commented Sep 3, 2020

@icco can you look again - I forgot to, ya know, serve the files

lol. I assumed the static serving was already happening. whoops.

@google-oss-robot google-oss-robot merged commit 562dda2 into main Sep 3, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/faaaaaaav branch September 3, 2020 20:05
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a favicon.ico
3 participants