-
Notifications
You must be signed in to change notification settings - Fork 83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for one small question. Feel free to submit.
* Must be `confirmed`, `likely`, `negative` | ||
* valid values depends on your realm's settings | ||
* `tzOffset` | ||
* Offset in minutes of the user's timezone. Positive, negative, 0, or omitted (using the default of 0) are all valid. 0 is considered to be UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minutes? Isn't this usually hours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the way it is in the api - not all TZ offsets are even hour increments
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: icco, mikehelmick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs/api.md
Outdated
"testDate": "YYYY-MM-DD", | ||
"testType": "<valid test type>", | ||
"tzOffset": 0, | ||
"phone": "+1NPANXXLINE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made clearer - was https://en.wikipedia.org/wiki/North_American_Numbering_Plan#Modern_plan
/unhold |
/lgtm |
Fixes #469
Proposed Changes
Release Note