Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Restore the old API key code #451

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Restore the old API key code #451

merged 1 commit into from
Sep 2, 2020

Conversation

sethvargo
Copy link
Member

Semi-revert of GH-239. This adds two "error" fields to our responses, but it's the best interim solution I can think of.

/assign @mikehelmick

Release Note

Temporarily return `error_code` and `errorCode` in API JSON responses for backwards compatibility. `error_code` will be removed in a future version.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 2, 2020
@sethvargo
Copy link
Member Author

/hold

See chat

@mikehelmick
Copy link
Contributor

this is fine - it will be essentially impossible to deprecate.
If we ever create a v2 of the API, we can really remove it.

/lgtm
/unhold

@google-oss-robot google-oss-robot merged commit b656fe7 into main Sep 2, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/oldcode branch September 2, 2020 02:30
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants