This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Create e2e-runner service. #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
google-cla
bot
added
the
cla: yes
google-oss-robot
requested review from
jeremyfaller,
mikehelmick and
sethvargo
This commit refactored the existing e2e-test CLI into a web service. It currently provides /default and /revise handlers, maps to the `-revise=false` and `-revise=true` flag of the original CLI. This service is currently guarded by an IAM policy to avoid hammering the API servers repeatedly.
yegle
force-pushed
the
e2e-tool-refactoring
branch
from
3c3afab
to
56f1f36
Compare
|
/cc @icco |
icco
reviewed
Aug 30, 2020
|
All comments addressed. PTAL. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: icco, yegle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactored the existing e2e-test CLI into a web service.
It currently provides /default and /revise handlers, maps to the
-revise=falseand-revise=trueflag of the original CLI.This service is currently guarded by an IAM policy to avoid hammering
the API servers repeatedly.
Fixes #265
Release Note*