This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Keepalive #393
Merged
Keepalive #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sethvargo
reviewed
Aug 27, 2020
| @@ -130,6 +137,10 @@ func (db *Database) OpenWithCacher(ctx context.Context, cacher cache.Cacher) err | |||
| return fmt.Errorf("database gorm.Open: %w", err) | |||
| } | |||
|
|
|||
| if c.MaxConnectionIdleTime > 0 { | |||
There was a problem hiding this comment.
I haven't done as much research here, but wouldn't SetConnMaxLifetime work better (and avoid all this overhead)?
db.DB().SetConnMaxLifetime(1*time.Minute)There was a problem hiding this comment.
made that the default - we can start there and see if it helps
|
just idle closes at first |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note