Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Set 1m idle timeout on Redis connections #391

Merged

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented Aug 27, 2020

Centralize our Redis configuration and set a 1m idle timeout on all Redis connections

Release Note

Set a 1m idle timeout on all Redis connections. `REDIS_HOST` and `REDIS_PORT` are now prefixed based on their scope (e.g. `CACHE_REDIS_HOST` and `RATE_LIMIT_REDIS_HOST`). This enables using a different Redis cluster or configuration for rate limiting vs caching.

/assign @mikehelmick
/assign @icco

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 27, 2020
@@ -0,0 +1,32 @@
// Copyright 2020 Google LLC
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be it's own package because otherwise we have a circular dep

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 712c4a2 into main Aug 27, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/idle_hands_are_the_redis_playground branch August 27, 2020 00:49
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants