Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Metrics #384

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Metrics #384

merged 4 commits into from
Aug 26, 2020

Conversation

mikehelmick
Copy link
Contributor

For #38

Proposed Changes

  • Add metrics to code issue, verify and certificate APIs

Release Note

Adds open census metrics for main API flows.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 26, 2020
@mikehelmick mikehelmick requested a review from icco August 26, 2020 20:45
icco
icco reviewed Aug 26, 2020
View reviewed changes
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
cmd/adminapi/main.go Show resolved Hide resolved
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
@mikehelmick
Copy link
Contributor Author

refactored + added attempt metrics

@mikehelmick
Copy link
Contributor Author

/retest

sethvargo
sethvargo reviewed Aug 26, 2020
View reviewed changes
pkg/controller/issueapi/issue.go Show resolved Hide resolved
pkg/observability/observability.go Outdated Show resolved Hide resolved
whaught
whaught approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@whaught whaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 2cda89f into google:main Aug 26, 2020
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@icco icco icco left review comments

@sethvargo sethvargo sethvargo left review comments

@whaught whaught whaught approved these changes

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

Assignees

@whaught whaught

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikehelmick @google-oss-robot @icco @sethvargo @whaught @googlebot