Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Expand the show code page to include more fields #375

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Aug 26, 2020

Proposed Changes

  • Adds the test type field
  • Adds information about either the
    • Issuing User Name
      OR
    • Issuing App Name

morefields

Release Note

Add test type and issuer to show code page 

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 26, 2020
Copy link
Contributor

@icco icco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like named returns in my go code, but the go wiki has feelings on the fact, so #shrugs https://github.com/golang/go/wiki/CodeReviewComments#named-result-parameters

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit fd91321 into google:main Aug 26, 2020
@whaught whaught deleted the E-X-P-A-N-D branch August 26, 2020 15:13
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants