Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add an LB in front of cloud run services #248

Merged
merged 16 commits into from
Aug 20, 2020
Merged

Add an LB in front of cloud run services #248

merged 16 commits into from
Aug 20, 2020

Conversation

icco
Copy link
Contributor

@icco icco commented Aug 16, 2020 •
edited
Loading

Proposed Changes

  • Adds regional NEG for each cloud run service
  • Adds an IP to put the LB behind

Release Note

NONE

@google-oss-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 16, 2020
@icco
Copy link
Contributor Author

icco commented Aug 16, 2020

This is draft because hashicorp/terraform-provider-google-beta#2348 isn't released yet.

sethvargo
sethvargo reviewed Aug 17, 2020
View reviewed changes
terraform/lb.tf Outdated Show resolved Hide resolved
terraform/lb.tf Outdated Show resolved Hide resolved
terraform/lb.tf Outdated Show resolved Hide resolved
@icco icco mentioned this pull request Aug 18, 2020
Closed
@icco icco marked this pull request as ready for review August 19, 2020 20:36
@icco
Copy link
Contributor Author

icco commented Aug 19, 2020

/assign @sethvargo

@mikehelmick
Copy link
Contributor

I'm going let seth approve due, but this looks fine to me.

also - you have a merge conflict now.

sethvargo
sethvargo reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

terraform/lb.tf
# See the License for the specific language governing permissions and
# limitations under the License.

# TODO(icco): This is currently all setup manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying our Terraform setup isn't currently managing this? We should probably merge as-is and then import the existing state. I can help with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mixture, the uncommented things we'll need to import. The commented things are currently broken in google-beta. hashicorp/terraform-provider-google#7051 will fix it in the next release.

@sethvargo
Copy link
Member

/lgtm

@icco do you wanna do the Terraform import or should I?

@google-oss-robot google-oss-robot merged commit d0f720c into google:main Aug 20, 2020
@icco icco deleted the lb branch August 20, 2020 17:00
@sethvargo
Copy link
Member

Deployed

@google google locked and limited conversation to collaborators Oct 6, 2020
@icco icco restored the lb branch October 6, 2020 20:52
@icco icco deleted the lb branch October 6, 2020 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo left review comments

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@icco @google-oss-robot @mikehelmick @sethvargo @googlebot