Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Lower Cloud KMS database-encrypter rotation to 90d #2019

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Lower Cloud KMS database-encrypter rotation to 90d #2019

merged 1 commit into from
Apr 12, 2021

Conversation

sethvargo
Copy link
Member

Release Note

Lower Cloud KMS database-encrypter rotation to 90d

@sethvargo sethvargo requested a review from a team as a code owner April 12, 2021 14:57
@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Apr 12, 2021
whaught
whaught approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@whaught whaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower? Aren't we raising it from 30 here?

@sethvargo
Copy link
Member Author

Lower? Aren't we raising it from 30 here?

We're lowering the frequency (every 30d to 90d). I do see how this is confusing though.

@sethvargo sethvargo merged commit ceb19fc into main Apr 12, 2021
@sethvargo sethvargo deleted the sethvargo/kms_rotate branch April 12, 2021 16:45
sethvargo added a commit that referenced this pull request Apr 13, 2021
@sethvargo
Lower Cloud KMS database-encrypter rotation to 90d (#2019)
7a63ea2
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@whaught whaught whaught approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees
No one assigned
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA. kind/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethvargo @whaught