Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

add some UX fixes #1989

Merged
merged 4 commits into from
Apr 6, 2021
Merged

add some UX fixes #1989

merged 4 commits into from
Apr 6, 2021

Conversation

mikehelmick
Copy link
Contributor

Proposed Changes

  • don't let greyed out fields be changed
  • alert if user exists

Release Note

Don't let greyed out fields be changed in signing keys.
Alert when creating a user that already exists.
Fix ENX upgrade SMS template text when user-report is enabled.

@mikehelmick mikehelmick requested a review from a team as a code owner April 6, 2021 16:34
@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Apr 6, 2021
@mikehelmick mikehelmick enabled auto-merge (squash) April 6, 2021 16:46
sethvargo
sethvargo suggested changes Apr 6, 2021
View reviewed changes
pkg/controller/user/create.go Outdated Show resolved Hide resolved
pkg/controller/realmadmin/settings_modify.go Outdated Show resolved Hide resolved
pkg/controller/realmkeys/save.go
@@ -61,8 +61,11 @@ func (c *Controller) HandleSave() http.Handler {
}

// Update settings.
currentRealm.CertificateIssuer = form.Issuer
currentRealm.CertificateAudience = form.Audience
if !currentRealm.UseRealmCertificateKey {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an error instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this - I went w/ the easier thing since this is unlikely to happen to a human not trying to get around this.

@mikehelmick mikehelmick merged commit 9696e62 into google:main Apr 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@whaught whaught Awaiting requested review from whaught

Assignees
No one assigned
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehelmick @sethvargo @googlebot