This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
More internationalization #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does 5 separate things: 1. Switch to using dir="rtl" and correctly setting the HTML lang attribute instead of relying on CSS to do the styling. This is needed for user stylesheets, but also sets us up better to migrate to bootstrap 5 which has better support for RTL languages. 2. Fix i18n reloading in development. In DEV_MODE, templates are automatically reloaded without the need to restart the server. 3. Fix the naming for Filipino. PH is not the correct code, it's FIL. 4. Pull account information from the Firebase cookie instead of doing a runtime lookup. The reduces the change of hitting firebase quota limits. 5. Add new translations for the account page.
googlebot
added
the
cla: yes
mikehelmick
approved these changes
Apr 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1970
This commit does 5 separate things:
Switch to using dir="rtl" and correctly setting the HTML lang attribute instead of relying on CSS to do the styling. This is needed for user stylesheets, but also sets us up better to migrate to bootstrap 5 which has better support for RTL languages.
Fix i18n reloading in development. In DEV_MODE, templates are automatically reloaded without the need to restart the server.
Fix the naming for Filipino. PH is not the correct code, it's FIL.
Pull account information from the Firebase cookie instead of doing a runtime lookup. The reduces the change of hitting firebase quota limits.
Add new translations for the account page.
Release Note