Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

allow admin /api/issue to issue user-report codes #1955

Merged
merged 2 commits into from
Mar 26, 2021
Merged

allow admin /api/issue to issue user-report codes #1955

merged 2 commits into from
Mar 26, 2021

Conversation

mikehelmick
Copy link
Contributor

Towards #1928

Proposed Changes

  • Add realm setting to enable "admin" API user-reports
    • these don't require a nonce
    • do require a phone number and still de-dupe against the HMAC user_report phone index

Release Note

All admin actions to issue user-report level verification codes, that can result in SELF_REPORT

@mikehelmick mikehelmick added the kind/enhancement New feature or feature request. label Mar 26, 2021
@mikehelmick mikehelmick requested a review from a team as a code owner March 26, 2021 03:59
@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Mar 26, 2021
sethvargo
sethvargo suggested changes Mar 26, 2021
View reviewed changes
pkg/database/migrations.go Outdated Show resolved Hide resolved
@mikehelmick mikehelmick merged commit ca5c1b6 into google:main Mar 26, 2021
@mikehelmick mikehelmick deleted the adminSelfReport branch March 26, 2021 23:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mariliamelo mariliamelo Awaiting requested review from mariliamelo

Assignees
No one assigned
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA. kind/enhancement New feature or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehelmick @sethvargo @googlebot