This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add self report #1930
Merged
Add self report #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
whaught
reviewed
Mar 20, 2021
whaught
reviewed
Mar 20, 2021
pkg/controller/issueapi/gen_code.go
Outdated
| if errors.Is(err, database.ErrAlreadyReported) { | ||
| return &IssueResult{ | ||
| obsResult: enobs.ResultError("DUPLICATE_USER_REPORT"), | ||
| HTTPCode: http.StatusTooManyRequests, |
There was a problem hiding this comment.
I feel like StatusTooManyRequests implies rate-limiting? Would conflict be more appropriate?
There was a problem hiding this comment.
other ideas, just 400? 403?
There was a problem hiding this comment.
409 would be most appropriate. I think we need to document the response and explain what clients should do instead.
sethvargo
suggested changes
Mar 20, 2021
| # Create secret for the database HMAC for phone numbers | ||
| resource "random_id" "db-phone-number-hmac" { | ||
| count = var.db_phone_number_hmac_count | ||
| byte_length = 128 |
There was a problem hiding this comment.
Some of the comments say 256?
There was a problem hiding this comment.
this is the HMAC secret length, not the nonce length
|
updated + added api docs. |
sethvargo
suggested changes
Mar 22, 2021
|
Test failures seem real? |
sethvargo
previously approved these changes
Mar 22, 2021
sethvargo
approved these changes
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1928
Proposed Changes
New checkbox to enable user report
New SMS template for "User Report"
Release Note